BREAKING(core): move build cache checks out of App.prototype.handler()#2931
Closed
iuioiua wants to merge 1 commit into
Closed
BREAKING(core): move build cache checks out of App.prototype.handler()#2931iuioiua wants to merge 1 commit into
App.prototype.handler()#2931iuioiua wants to merge 1 commit into
Conversation
marvinhagemeister
left a comment
marvinhagemeister
left a comment
Contributor
There was a problem hiding this comment.
Checking for the build cache is something that should be checked upon listening.
Are you saying that user's should do this check themselves?
const handler = app.handler();
Deno.serve(handler)How would we hook into the listen aspect here?
Contributor
Author
|
Maybe we could move the build logic into a new |
Contributor
Author
|
I'll revisit this once approaching |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App.prototype.handler()is now more accurately named as it's now a handler rather than a handler factory. Checking for the build cache is something that should be checked upon listening.Needed for #2896